In article <[email protected]> (at Tue, 18 Oct 2005 16:09:27 +1000), Andrew Hendry <[email protected]> says:
> +/*
> +* ITU DTE facilities
> +* Only the called and calling address
> +* extension are currently implemented.
> +* The rest are in place to avoid the struct
> +* changing size if someone needs them later
> ++ */
> +struct x25_dte_facilities {
> + unsigned int calling_len, called_len;
> + char calling_ae[20];
> + char called_ae[20];
> + unsigned char min_throughput;
> + unsigned short delay_cumul;
> + unsigned short delay_target;
> + unsigned short delay_max;
> + unsigned char expedited;
> +};
Why don't you use fixed size members?
And we can eliminate 8bit hole.
struct x25_dte_facilities {
u32 calling_len
u32 called_len;
u8 calling_ae[20];
u8 called_ae[20];
u8 min_throughput;
u8 expedited;
u16 delay_cumul;
u16 delay_target;
u16 delay_max;
};
--yoshfuji
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
