Re: [PATCH 1/2] miss-sync changes on attributes (Re: [PATCH 2/2][FAT] miss-sync issues on sync mount (miss-sync on utime))

OGAWA Hirofumi wrote:

"Machida, Hiroyuki" <[email protected]> writes:

OGAWA Hirofumi wrote:

Andrew Morton <[email protected]> writes:

However there's not much point in writing a brand-new function when
write_inode_now() almost does the right thing.  We can share the
implementation within fs-writeback.c.

Indeed. We use the generic_osync_inode() for it?

Please let me confirm.
Using generic_osync_inode(inode, NULL, OSYNC_INODE) instaed of
sync_inode_wodata(inode) is peferable for changes on fs/open.c,
even it would write data. Is it correct?

No, I only thought the interface is good. I don't know why it writes
data pages even if OSYNC_INODE only.

I checked 2.6.13 tree, following functions call generic_osync_inode().
However noone calls it with OSYNC_INODE. SO I can't find intention of
it's usage.

Does anyone know why generic_osync_inode() trys to write data page,
even if OSYNC_INODE only passed ?

  - fs/reiserfs/file.c
	reiserfs_file_write()		OSYNC_METADATA | OSYNC_DATA
  - mm/filemap.c
	sync_page_range()		OSYNC_METADATA
	sync_page_range_nolock()	OSYNC_METADATA
	generic_file_direct_write	OSYNC_METADATA




--
Hiroyuki Machida		[email protected]		
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH] generic_osync_inode() with OSYNC_INODE only passed (Re: [PATCH 1/2] miss-sync changes on attributes)
    • From: "Machida, Hiroyuki" <[email protected]>
  • [PATCH] generic_osync_inode() with OSYNC_INODE only passed (Re: [PATCH 1/2] miss-sync changes on attributes)
    • From: "Machida, Hiroyuki" <[email protected]>

• References:
  • Re: [PATCH 1/2] miss-sync changes on attributes (Re: [PATCH 2/2][FAT] miss-sync issues on sync mount (miss-sync on utime))
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 1/2] miss-sync changes on attributes (Re: [PATCH 2/2][FAT] miss-sync issues on sync mount (miss-sync on utime))
    • From: OGAWA Hirofumi <[email protected]>
  • Re: [PATCH 1/2] miss-sync changes on attributes (Re: [PATCH 2/2][FAT] miss-sync issues on sync mount (miss-sync on utime))
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 1/2] miss-sync changes on attributes (Re: [PATCH 2/2][FAT] miss-sync issues on sync mount (miss-sync on utime))
    • From: OGAWA Hirofumi <[email protected]>
  • Re: [PATCH 1/2] miss-sync changes on attributes (Re: [PATCH 2/2][FAT] miss-sync issues on sync mount (miss-sync on utime))
    • From: "Machida, Hiroyuki" <[email protected]>
  • Re: [PATCH 1/2] miss-sync changes on attributes (Re: [PATCH 2/2][FAT] miss-sync issues on sync mount (miss-sync on utime))
    • From: OGAWA Hirofumi <[email protected]>

• Prev by Date: Re: bttv card after swsusp dead
• Next by Date: Re: [Lhms-devel] [PATCH 8/8] Fragmentation Avoidance V17: 008_stats
• Previous by thread: Re: [PATCH 1/2] miss-sync changes on attributes (Re: [PATCH 2/2][FAT] miss-sync issues on sync mount (miss-sync on utime))
• Next by thread: [PATCH] generic_osync_inode() with OSYNC_INODE only passed (Re: [PATCH 1/2] miss-sync changes on attributes)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]