On Mon, Oct 10, 2005 at 23:39:28 +0200, Pavel Machek wrote: > Hi! > > > Signed-off-by: Ken Preslan <[email protected]> > > Signed-off-by: David Teigland <[email protected]> > > > + for (; blks; gfs2_replay_incr_blk(sdp, &start), blks--) { > > > + for (head = &ai->ai_ail1_list, tmp = head->prev, prev = tmp->prev; > > + tmp != head; > > + tmp = prev, prev = tmp->prev) { > > > > + for (head = &ai->ai_ail1_list, tmp = head->prev, prev = tmp->prev; > > + tmp != head; > > + tmp = prev, prev = tmp->prev) { > > > Can you get less creative in the for loops? [There are more examples > at other patches, for (i=something; i--; ) was "nicest" example]. The later two are good examples of where list_for_each_safe is appropriate. -- Jan 'Bulb' Hudec <[email protected]>
Attachment:
signature.asc
Description: Digital signature
- Follow-Ups:
- Re: [PATCH 03/16] GFS: core fs
- From: David Teigland <[email protected]>
- Re: [PATCH 03/16] GFS: core fs
- References:
- [PATCH 03/16] GFS: core fs
- From: David Teigland <[email protected]>
- Re: [PATCH 03/16] GFS: core fs
- From: Pavel Machek <[email protected]>
- [PATCH 03/16] GFS: core fs
- Prev by Date: Errors while initializing mptspi on 53C1030
- Next by Date: linux 2.6.13.3+ext3: journal block not found
- Previous by thread: Re: [PATCH 03/16] GFS: core fs
- Next by thread: Re: [PATCH 03/16] GFS: core fs
- Index(es):
 |