Re: [PATCH 03/16] GFS: core fs

[Pavel Machek <pavel@ucw.cz>]

Hi!

> Signed-off-by: Ken Preslan <ken@preslan.org>
> Signed-off-by: David Teigland <teigland@redhat.com>

> +	for (; blks; gfs2_replay_incr_blk(sdp, &start), blks--) {

> +		for (head = &ai->ai_ail1_list, tmp = head->prev, prev = tmp->prev;
> +		     tmp != head;
> +		     tmp = prev, prev = tmp->prev) {


> +	for (head = &ai->ai_ail1_list, tmp = head->prev, prev = tmp->prev;
> +	     tmp != head;
> +	     tmp = prev, prev = tmp->prev) {


Can you get less creative in the for loops? [There are more examples
at other patches, for (i=something; i--; ) was "nicest" example].

> +		for (;;) {

while(1) seems to be more common in kernel.

								Pavel
-- 
if you have sharp zaurus hardware you don't need... you know my address
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/