Re: [PATCH] Fix ext3 warning for unused var

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Linus Torvalds wrote:

On Sun, 9 Oct 2005, Paolo 'Blaisorblade' Giarrusso wrote:
Can please someone merge this? It's the 3rd time I send it.

I don't like #ifdef's in code. You could just have split up the quota-specific stuff into a function of their own: "ext3_show_quota_options()". The patch might have been larger, but it would actually clean up the code rather than make it uglier.

Warnings are not a reason for ugly code.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Someone needs to fix fsck.ext3 while they are at it so it doesn't barf when reading from reisferfs filesystems and return a command return of > 2 during scanning of parttions during bootup. This looks like some sort of anti-competitive crap and it doesn't belong in fsck.ext3 since reiserfs is in the kernel.

J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux