Re: [PATCH] gfp flags annotations - part 1

> > --- RC14-rc3-git4-linus-delta/drivers/s390/scsi/zfcp_aux.c
> > +++ current/drivers/s390/scsi/zfcp_aux.c
> 
> >  static void *
> > -zfcp_mempool_alloc(unsigned int __nocast gfp_mask, void *size)
> > +zfcp_mempool_alloc(gfp_t gfp_mask, void *size)
> >  {
> >  	return kmalloc((size_t) size, gfp_mask);
> >  }
> 
> Lovely. Yes, they cast sizeof() to void * in all calls.

zfcp_mempool_alloc needs to fit the prototype of mempool_alloc_t.
If you have a better idea to implement a mempool, please let us
know. The calls you mention are actually calls to mempool_create
and not to zfcp_mempool_alloc, or are you talking about
something different?

Heiko
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] gfp flags annotations - part 1
    • From: Alexey Dobriyan <[email protected]>

• References:
  • [PATCHSET] 2.6.14-rc3-git4-bird1
    • From: Al Viro <[email protected]>
  • Re: [PATCHSET] 2.6.14-rc3-git4-bird1
    • From: Alexey Dobriyan <[email protected]>
  • [RFC] gfp flags annotations
    • From: Al Viro <[email protected]>
  • Re: [RFC] gfp flags annotations
    • From: Greg KH <[email protected]>
  • Re: [PATCH] gfp flags annotations - part 1
    • From: Alexey Dobriyan <[email protected]>

• Prev by Date: Re: [PATCH] vm - swap_prefetch-15
• Next by Date: [2.6] binfmt_elf bug (exposed by klibc).
• Previous by thread: Re: [PATCH] gfp flags annotations - part 1
• Next by thread: Re: [PATCH] gfp flags annotations - part 1
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]