Re: [PATCH 2.6.14-rc2 0/2] libata: Marvell SATA support (v0.23-0.24)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Brett Russ wrote:
Jeff Garzik wrote:

Staring at the docs a bit, I notice that the 50xx and 60xx have SATA S{status,control,error} registers at different locations.



Yes and also even some registers that are at the same location have changed bit definitions. Aye caramba.

Best solution will probably be to create separate enums for each chip generation, in addition to a common enum, and point to the relevant one based on the chip identifier.

No surprise we're seeing so many problems. I have just not spent any time at all on 5xxx. Probably should yank it from the pci device table for now.

I would suggest submitting a patch to put #if 0 around the PCI table entries, so that testers can easily turn it back on...

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux