Borislav Petkov <[email protected]> wrote:
>
> Hi,
>
> The following patch removes the check_region call in the PnPWakeUp
> path in the Eepro /10 ISA driver. Instead, now it calls request_region
> for the PnP wake up routine and, after succeeding, it calls release_region
> for the actual reservation of I/O ports takes place in the eepro_probe1()
> function straight afterwards.
>
> Signed-off-by: Borislav Petkov <[email protected]>
>
>
> --- drivers/net/eepro.c.orig 2005-09-22 06:20:28.000000000 +0200
> +++ drivers/net/eepro.c 2005-09-22 07:20:16.000000000 +0200
> @@ -552,7 +552,7 @@ static int __init do_eepro_probe(struct
> {
> unsigned short int WS[32]=WakeupSeq;
>
> - if (check_region(WakeupPort, 2)==0) {
> + if (request_region(WakeupPort, 2, DRV_NAME)) {
>
> if (net_debug>5)
> printk(KERN_DEBUG "Waking UP\n");
> @@ -563,6 +563,8 @@ static int __init do_eepro_probe(struct
> outb_p(WS[i],WakeupPort);
> if (net_debug>5) printk(KERN_DEBUG ": %#x ",WS[i]);
> }
> + release_region(WakeupPort, 2);
> +
> } else printk(KERN_WARNING "Checkregion Failed!\n");
> }
> #endif
hm, that's all a bit strange. It would be better to do the
request_region() just once and if that works, retain the reservation rather
than releasing and reacquiring it.
That being said, the code you've modified is disabled due to
!defined(PnPWakeup), and the chances of anyone ever changing that are close
to zero.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |