Re: [PATCH] bond_main.c: fix device deregistration in init exception path

Andrew Morton wrote:

diff -puN drivers/net/bonding/bond_main.c~bond_mainc-fix-device-deregistration-in-init-exception drivers/net/bonding/bond_main.c
--- devel/drivers/net/bonding/bond_main.c~bond_mainc-fix-device-deregistration-in-init-exception	2005-09-17 23:18:38.000000000 -0700
+++ devel-akpm/drivers/net/bonding/bond_main.c	2005-09-17 23:31:02.000000000 -0700
@@ -5039,6 +5039,14 @@ static int __init bonding_init(void)
 	return 0;

out_err:

+	/*
+	 * rtnl_unlock() will run netdev_run_todo(), putting the
+	 * thus-far-registered bonding devices into a state which
+	 * unregigister_netdevice() will accept
+	 */
+	rtnl_unlock();
+	rtnl_lock();
+

Don't we want a schedule() or schedule_timeout(1) in between?

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] bond_main.c: fix device deregistration in init exception path
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] bond_main.c: fix device deregistration in init exception path
    • From: Al Viro <[email protected]>

• References:
  • [PATCH] bond_main.c: fix device deregistration in init exception path
    • From: Florin Malita <[email protected]>
  • Re: [PATCH] bond_main.c: fix device deregistration in init exception path
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [PATCH 2.6.14-rc1] Fix broken NVIDIA device ID in sata_nv
• Next by Date: Re: A pettiness question.
• Previous by thread: Re: [PATCH] bond_main.c: fix device deregistration in init exception path
• Next by thread: Re: [PATCH] bond_main.c: fix device deregistration in init exception path
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]