Re: [PATCH] bond_main.c: fix device deregistration in init exception path

From: Andrew Morton <[email protected]>
Date: Sat, 17 Sep 2005 23:32:24 -0700

> The fix is solid enough, although a better comment is needed.  Let's
> let Dave decide whether that was a sane thing to go BUG over..

The fix is fine and so is the BUG() check.

Usually, you're supposed to make sure that the very last thing
you do is register_netdev(), and that all possible errors are
possible only before that call.

And that's what BOND basically does, except that it must register
multiple devices in a loop and therefore cannot follow that rule
precisely.

So I've added the patch to my tree, it's fine to do this for a
special case usage like this one.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] bond_main.c: fix device deregistration in init exception path
    • From: Florin Malita <[email protected]>
  • Re: [PATCH] bond_main.c: fix device deregistration in init exception path
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [Patch] Support UTF-8 scripts
• Next by Date: Re: Why don't we separate menuconfig from the kernel?
• Previous by thread: Re: [PATCH] bond_main.c: fix device deregistration in init exception path
• Next by thread: Re: [PATCH] bond_main.c: fix device deregistration in init exception path
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]