On Wed, Sep 21, 2005 at 03:36:01AM +0100, Al Viro wrote: > On Tue, Sep 20, 2005 at 09:41:47PM -0400, John McCutchan wrote: > > I grepped all the filesystems > > ... in the tree > > > , and they all seem to use > > generic_drop_inode, except for hugetlbfs, which seems to have the same > > logic of (!inode->i_nlink). > > I have no problems with killing ->drop_inode(), but that should be > a) done for in-tree filesystems > b) announced on fsdevel, so that out-of-tree folks could deal > with that > c) given at least one release to avoid screwing them. > > Christoph, could you send the patch you've mentioned? I'd rather avoid > duplicating what you've done... sure. Note that clusterfs folks (ocfs2 in particular) really want ->drop_inode because they need additional checks instead of just the nlink one in there. While hugetlbfs should just go away ->drop_inode makes some sense for them. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- References:
- Re: [patch] stop inotify from sending random DELETE_SELF event under load
- From: John McCutchan <[email protected]>
- Re: [patch] stop inotify from sending random DELETE_SELF event under load
- From: Al Viro <[email protected]>
- Re: [patch] stop inotify from sending random DELETE_SELF event under load
- From: Ray Lee <[email protected]>
- Re: [patch] stop inotify from sending random DELETE_SELF event under load
- From: Linus Torvalds <[email protected]>
- Re: [patch] stop inotify from sending random DELETE_SELF event under load
- From: Al Viro <[email protected]>
- Re: [patch] stop inotify from sending random DELETE_SELF event under load
- From: Linus Torvalds <[email protected]>
- Re: [patch] stop inotify from sending random DELETE_SELF event under load
- From: John McCutchan <[email protected]>
- Re: [patch] stop inotify from sending random DELETE_SELF event under load
- From: Al Viro <[email protected]>
- Re: [patch] stop inotify from sending random DELETE_SELF event under load
- From: John McCutchan <[email protected]>
- Re: [patch] stop inotify from sending random DELETE_SELF event under load
- From: Al Viro <[email protected]>
- Re: [patch] stop inotify from sending random DELETE_SELF event under load
- Prev by Date: Re: OOPS in raid10.c:1448 in vanilla 2.6.13.2
- Next by Date: Re: one more oops on sensor modules removal
- Previous by thread: Re: [patch] stop inotify from sending random DELETE_SELF event under load
- Next by thread: Re: [patch] stop inotify from sending random DELETE_SELF event under load
- Index(es):
