Hi!
> > FYI, my hacks now look like (attached). I'll push changes to linux-z
> > in few hours.
>
> Some questions:
>
> @@ -57,8 +57,6 @@ void dump_backtrace_entry(unsigned long
> #ifdef CONFIG_KALLSYMS
> printk("[<%08lx>] ", where);
> print_symbol("(%s) ", where);
> - printk("from [<%08lx>] ", from);
> - print_symbol("(%s)\n", from);
>
> The "from" address provides good hints about the exact path we got to
> the called function. You don't really want to get rid of that because
> it makes following backtraces harder. I'm not sure why you've made
> the other changes in that file either.
Well, zaurus console is something like 40x20 characters. Normal
backtrace does not fit there, and it has most important info at the
top.
> +/* those must never be empty
> + unfortunately they cause problems with older binutils
> ASSERT((__proc_info_end - __proc_info_begin), "missing CPU support")
> ASSERT((__arch_info_end - __arch_info_begin), "no machine record defined")
> +*/
>
> Get a better binutils. 8)
Yep :-). Those can wait.
> diff --git a/drivers/mfd/mcp-core.c b/drivers/mfd/mcp-core.c
> --- a/drivers/mfd/mcp-core.c
> +++ b/drivers/mfd/mcp-core.c
> @@ -19,6 +19,7 @@
> #include <asm/dma.h>
> #include <asm/system.h>
>
> +#include <asm/arch/mcp.h>
> #include "mcp.h"
>
> #define to_mcp(d) container_of(d, struct mcp, attached_device)
>
> This looks bogus - why is this needed?
Can go, fixed. (Remainings of previous patches).
> @@ -186,7 +192,12 @@ static int mcp_sa11x0_probe(struct devic
> */
> Ser4MCSR = -1;
> Ser4MCCR1 = data->mccr1;
> - Ser4MCCR0 = data->mccr0 | 0x7f7f;
> +#if 1
> + if (machine_is_collie())
> + Ser4MCCR0 = MCCR0_ADM | MCCR0_ExtClk;
> + else
> +#endif
> + Ser4MCCR0 = data->mccr0 | 0x7f7f;
>
> Ditto.
I tried to kill that one before, and it broke boot. I have little idea
how to debug that one...
Pavel
--
Boycott Kodak -- for their patent abuse against Java.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |