Re: [PATCH] introduce setup_timer() helper

> 				unsigned long data)
> +{
> +	timer->function = function;
> +	timer->data = data;
> +	init_timer(timer);
> +}

are you sure you want to do this in this order???
I'd expect the init_timer to be first...

Attachment: signature.asc
Description: This is a digitally signed message part

---

• Follow-Ups:
  • Re: [PATCH] introduce setup_timer() helper
    • From: Oleg Nesterov <[email protected]>

• References:
  • [PATCH] introduce setup_timer() helper
    • From: Oleg Nesterov <[email protected]>

• Prev by Date: Re: [KORG] REMINDER: master.kernel.org extended downtime
• Next by Date: Sis695 southbridge support (Asus K8S-MX)
• Previous by thread: [PATCH] introduce setup_timer() helper
• Next by thread: Re: [PATCH] introduce setup_timer() helper
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]