On Wed, 2005-09-14 at 13:20 +0200, Stefan Smietanowski wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Andrew Morton wrote: > > Harald Welte <[email protected]> wrote: > > > >>Add new Omnikey Cardman 4000 smartcard reader driver > > > > > > - All the open-coded mdelays() are wrong: > > > > #define T_10MSEC msecs_to_jiffies(10) > > ... > > mdelay(T_10MSEC); > > > > mdelay() already takes a jiffies argument. > > And isn't that what he's doing? Andrew had a slippian freud; mdelay takes miliseconds as argument.
Attachment:
signature.asc
Description: This is a digitally signed message part
- References:
- [PATCH 2/2] New Omnikey Cardman 4000 driver
- From: Harald Welte <[email protected]>
- Re: [PATCH 2/2] New Omnikey Cardman 4000 driver
- From: Andrew Morton <[email protected]>
- Re: [PATCH 2/2] New Omnikey Cardman 4000 driver
- From: Stefan Smietanowski <[email protected]>
- [PATCH 2/2] New Omnikey Cardman 4000 driver
- Prev by Date: seq_file problem
- Next by Date: Re: [PATCH] Fix commit of ordered data buffers
- Previous by thread: Re: [PATCH 2/2] New Omnikey Cardman 4000 driver
- Next by thread: [PATCH] Omnikey CardMan 4000 update
- Index(es):