From: Linus Torvalds <[email protected]>
Date: Tue, 13 Sep 2005 08:55:31 -0700 (PDT)
> > /* Reset expansion ROM address decode enable */
> > pci_read_config_word(ha->pdev, PCI_ROM_ADDRESS, &w);
> > w &= ~PCI_ROM_ADDRESS_ENABLE;
> > pci_write_config_word(ha->pdev, PCI_ROM_ADDRESS, w);
...
> So the above probably works fine, especially since it's just disabling the
> ROM (ie we don't end up caring at all about the upper bits even if they
> did get the wrong value). But it's definitely bad practice, and there are
> probably cards (for which that driver is irrelevant, of course ;) where
> doing something like the above might not work at all.
I think for consistency the above driver case should still be fixed,
however. This way when people try to audit the tree for
PCI_ROM_ADDRESS config space accesses, they won't come across this
same instance again and again.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
|
|