On Sat, 10 Sep 2005 20:11:50 -0700, Greg KH <[email protected]> wrote:
>On Sat, Jul 30, 2005 at 02:54:17PM +1000, Grant Coady wrote:
>> On Fri, 29 Jul 2005 23:52:39 -0400, Jeff Garzik <[email protected]> wrote:
>> >
>> >However you did your search, you did it wrong. The very first two
>> >entries I tried had zero uses:
>> >
>> >[jgarzik@pretzel linux-2.6]$ grepsrc ICH7_22
>> >./include/linux/pci_ids.h:#define PCI_DEVICE_ID_INTEL_ICH7_22 0x27e0
>> >[jgarzik@pretzel linux-2.6]$ grepsrc ICH7_23
>> >./include/linux/pci_ids.h:#define PCI_DEVICE_ID_INTEL_ICH7_23 0x27e2
>> >[jgarzik@pretzel linux-2.6]$
>>
>> Sorry Jeff, excluding "include/linux/pci_ids.h" makes a huge difference :o)
>>
>> Does roughly 1/3 unused:
>>
>> 63065 2005-07-30 14:51 pci_ids-list
>> 19243 2005-07-30 14:52 pci_ids-not_used
>>
>> Seem in ballpark?
>
>Great, care to send me a patch that trims this file down?
Just ran the discovery script on 2.6.13.mm2, there's roughly 1609
symbols unused in pci_ids.h, another 1030 are defined throughout the
source tree, leaving 729 in pci_ids.h. Total unique symbols is 1030.
Not counted are macro defined symbols:
PCI_DEVICE_ID_##id
PCI_DEVICE_ID_##v##_##d
PCI_DEVICE_ID_BROOKTREE_##chip
PCI_VENDOR_ID_##v
from:
linux-2.6.13-mm2/drivers/video/cirrusfb.c
linux-2.6.13-mm2/sound/oss/ymfpci.c
linux-2.6.13-mm2/sound/pci/bt87x.c
What is the goal here? Is a comment stripped, non-duplicate pci_ids.h
with a reference to source site okay?
Should the various distributed defines be collected to the one header
file and that header be include'd to those files? It seems pci_ids.h
is redundant.
Thanks,
Grant.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |