Re: [PATCH 2.6.13 5/14] sas-class: sas_discover.c Discover process (end devices)

On 9/9/05, Luben Tuikov <[email protected]> wrote:
> Signed-off-by: Luben Tuikov <[email protected]>

<snip>


+static int sas_execute_task(struct sas_task *task, void *buffer, int size,
+                           int pci_dma_dir)

<snip>

+                       set_current_state(TASK_INTERRUPTIBLE);
+                       schedule_timeout(HZ);

<snip>

+                               set_current_state(TASK_INTERRUPTIBLE);
+                               schedule_timeout(5*HZ);

Can you use msleep_interruptible() here? I don't see wait-queues in
the immediate vicinity. If not, and you're going for the normal -mm
route (and from there to mainline), can you use
schedule_timeout_interruptible(), please?

Thanks,
Nish
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 2.6.13 5/14] sas-class: sas_discover.c Discover process (end devices)
    • From: Luben Tuikov <[email protected]>

• References:
  • [PATCH 2.6.13 5/14] sas-class: sas_discover.c Discover process (end devices)
    • From: Luben Tuikov <[email protected]>

• Prev by Date: Re: [PATCH 2.6.13 1/20] aic94xx: Makefile
• Next by Date: Re: [PATCH 2.6.13 9/14] sas-class: sas_expander.c Expander discovery and configuration
• Previous by thread: [PATCH 2.6.13 5/14] sas-class: sas_discover.c Discover process (end devices)
• Next by thread: Re: [PATCH 2.6.13 5/14] sas-class: sas_discover.c Discover process (end devices)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]