Re: [PATCH 2/25] NTFS: Allow highmem kmalloc() in ntfs_malloc_nofs() and add _nofail() version.

[Anton Altaparmakov <aia21@cam.ac.uk>]

On Fri, 2005-09-09 at 15:02 +0300, Pekka J Enberg wrote:
> On Fri, 9 Sep 2005, Anton Altaparmakov wrote:
> > > I completely disagree with you given that this is not "inventing [...]
> > > own memory allocators", it is just a convenient short hand.  I am sure a
> > > lot of people would agree with you though.  It is just a matter of
> > > personal preference.
> > 
> > I should add that this is not ntfs only, the idea is from another file
> > system which uses it, too.  Can't remember which one it was, though (xfs
> > maybe?).
> 
> Indeed. It is not just a matter of personal preference but also a matter 
> of subsystems introducing duplicate code like this. Quick grepping shows 
> UDF doing same thing  and XFS doing slightly differently but I am pretty 
> sure I've seen it elsewhere too.

Yes, that is usually a good indication that a generic function should be
provided.  However having a generic function with complicated and long
arguments is no use as everyone will want their own shorter one anyway.
And given the function is static inline it actually makes no difference
to the generated code size.  Also calling it __vmalloc_fast makes no
sense as it doesn't always use vmalloc...  Given we have kmalloc and
vmalloc maybe it should be just malloc?

Obviously if there were a suitable generic function I would use it but I
and I imagine all the other users would still wrap it with the old name.

Best regards,

        Anton
-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/