Re: [PATCH 3/3] Add disk hotswap support to libata RESEND #2

Regarding the sata_promise.c patch, I think I have found a bug in the
interrupt handler:

Just before the 'try_hotplug' label, you provide a check that will
kick us out of the interrupt handler if the interrupt was just handled
by a DMA command completing successfully.

However, I have seen the occasion where a single IRQ is used to signal
both a DMA completion AND a hotplug event.  Of course in this case the
hotplug event itself would be ignored completely.

So I would recommend getting rid of that check entirely.

-- 
Jim Ramsay
"Me fail English?  That's unpossible!"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 3/3] Add disk hotswap support to libata RESEND #2
    • From: Lukasz Kosewski <[email protected]>

• References:
  • [PATCH 3/3] Add disk hotswap support to libata RESEND #2
    • From: Lukasz Kosewski <[email protected]>
  • Re: [PATCH 3/3] Add disk hotswap support to libata RESEND #2
    • From: Jim Ramsay <[email protected]>
  • Re: [PATCH 3/3] Add disk hotswap support to libata RESEND #2
    • From: Jim Ramsay <[email protected]>
  • Re: [PATCH 3/3] Add disk hotswap support to libata RESEND #2
    • From: George Anzinger <[email protected]>
  • Re: [PATCH 3/3] Add disk hotswap support to libata RESEND #2
    • From: Stefan Richter <[email protected]>
  • Re: [PATCH 3/3] Add disk hotswap support to libata RESEND #2
    • From: Lukasz Kosewski <[email protected]>
  • Re: [PATCH 3/3] Add disk hotswap support to libata RESEND #2
    • From: Jim Ramsay <[email protected]>
  • Re: [PATCH 3/3] Add disk hotswap support to libata RESEND #2
    • From: Jim Ramsay <[email protected]>

• Prev by Date: Re: [PATCH] Arcnet, linux 2.6.13
• Next by Date: Re: 2.6.13: can kill X server but readlink of /proc/<pid>/exe et. al. says EACCES. feature?
• Previous by thread: Re: [PATCH 3/3] Add disk hotswap support to libata RESEND #2
• Next by thread: Re: [PATCH 3/3] Add disk hotswap support to libata RESEND #2
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]