(alpha) process_reloc_for_got confuses r_offset and r_addend

[Chaskiel Grundman <cg2v@andrew.cmu.edu>]

arch/alpha/kernel/module.c:process_reloc_for_got(), which figures out how 
big the .got section for a module should be, appears to be confusing 
r_offset (the file offset that the relocation needs to be applied to) with 
r_addend (the offset of the relocation's actual target address from the 
address of the relocation's symbol). Because of this, one .got entry is 
allocated for each relocation instead of one each unique symbol/addend.

In the module I am working with, this causes the .got section to be almost 
10 times larger than it needs to be (75544 bytes instead of 7608 bytes). 
As the .got is accessed with global-pointer-relative instructions, it 
needs to be within the 64k gp "zone", and a 75544 byte .got clearly does 
not fit. The result of this is that relocation overflows are detected 
during module load and the load is aborted.

Does anyone see anything wrong with this analysis? I tested a patch that 
makes the obvious change to struct got_entry/process_reloc_for_got and it 
seems to work ok.

(Please cc me on replies. thanks)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/