Re: x86-cache-pollution-aware-__copy_from_user_ll.patch added to -mm tree

Dave Jones <[email protected]> wrote:
>
> On Sun, Sep 04, 2005 at 01:16:00PM -0700, Andrew Morton wrote:
>   >  unsigned long __copy_to_user_ll(void __user *to, const void *from, unsigned long n)
>   >  {
>   >  	BUG_ON((long) n < 0);
> 
>  Ehh? It's unsigned. This will never be true.

It's cast to long, so it'll trap if we try to copy >=2G.

It seems a strange thing to check though.   Do we really need it?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: x86-cache-pollution-aware-__copy_from_user_ll.patch added to -mm tree
    • From: "David S. Miller" <[email protected]>
  • Re: x86-cache-pollution-aware-__copy_from_user_ll.patch added to -mm tree
    • From: Hiro Yoshioka <[email protected]>

• References:
  • Re: x86-cache-pollution-aware-__copy_from_user_ll.patch added to -mm tree
    • From: Dave Jones <[email protected]>

• Prev by Date: Re: 2.6.13-mm1
• Next by Date: Re: nfs4 client bug
• Previous by thread: Re: x86-cache-pollution-aware-__copy_from_user_ll.patch added to -mm tree
• Next by thread: Re: x86-cache-pollution-aware-__copy_from_user_ll.patch added to -mm tree
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]