Re: x86-cache-pollution-aware-__copy_from_user_ll.patch added to -mm tree

On Sun, Sep 04, 2005 at 01:16:00PM -0700, Andrew Morton wrote:
 >  unsigned long __copy_to_user_ll(void __user *to, const void *from, unsigned long n)
 >  {
 >  	BUG_ON((long) n < 0);

Ehh? It's unsigned. This will never be true.

 > +unsigned long
 > +__copy_from_user_ll_nocache(void *to, const void __user *from, unsigned long n)
 > +{
 > +	BUG_ON((long)n < 0);

Ditto.

		Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: x86-cache-pollution-aware-__copy_from_user_ll.patch added to -mm tree
    • From: "David S. Miller" <[email protected]>
  • Re: x86-cache-pollution-aware-__copy_from_user_ll.patch added to -mm tree
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: RFC: i386: kill !4KSTACKS
• Next by Date: Re: [PATCH 1/3] dynticks - implement no idle hz for x86
• Previous by thread: [patch] Bring the Vaio's RA826G HDA (82801) to life ...
• Next by thread: Re: x86-cache-pollution-aware-__copy_from_user_ll.patch added to -mm tree
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]