Re: Serial driver (serial_core.c) status messages should be set to KERN_INFO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

Jiri Slaby wrote:

Alon Bar-Lev napsal(a):

Hello,


When upgrading to 2.6.13 I've noticed that serial driver reports it status with unknown severity, causing the boot-splash to be overridden.


Please consider this modification.


Best Regards,

Alon Bar-Lev.


At drivers/serial/serial_core.c


static inline void

uart_report_port(struct uart_driver *drv, struct uart_port *port)
{
-        printk("%s%d", drv->dev_name, port->line);
+      printk(KERN_INFO + "%s%d", drv->dev_name, port->line);


plus sign between that?

You are right!!! the + is mistake.
The KERN_INFO is the main fix.



        printk(" at ");


why the fellows didn't put this to the line above?

Regarding the other comments... I really don't know... this is how the driver is written....
I would have constructed a string and only then printk it...

Regards,
Alon Bar-Lev.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]
  Powered by Linux