Re: [patch] IBM HDAPS accelerometer driver.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Of late I have been working on a driver for the IBM Hard Drive Active
Protection System (HDAPS), which provides a two-axis accelerometer and
some other misc. data.  The hardware is found on recent IBM ThinkPad
laptops.

The following patch adds the driver to 2.6.13-rc6-mm2.  It is
self-contained and fairly simple.

Do we really need input interface *and* sysfs interface? Input should be
enough.

I think he doesn't need to export it at all and he should write code to
park and disable hard disk instead.
(in userspace it's unsolvable --- i.e. you can't enable hard disk when
detected stable condition if the daemon is swapped out on that hard disk)

man mlockall() :-).

You also must not use any syscall that allocates even temporary memory in kernel (select, poll, many others ...) or that waits on semaphore that might be held while allocating memory (i.e. audit and rewrite ide ioctl path).

And you need extra flags to protect the daemon from being killed at shutdown or blocked at suspend.

I think writing it as kernel thread would be easir than all this.

Accelerometer is usefull for other stuff besides parking heads, like
playing marble madness or what is the name of the game, and even
parking heads is way too complex to be put into the kernel.

Even if you don't like mlockall(), you can put timeout into
disk-freezing interface.

That makes the protection less reliable (you shake the notebook and after the timeout drop it).

Mikulas

								Pavel
--
if you have sharp zaurus hardware you don't need... you know my address

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]
  Powered by Linux