Re: [PATCH][RESEND] don't allow sys_readahead() on files opened with O_DIRECT

On Thu, Aug 25, 2005 at 01:24:40AM -0700, Andrew Morton wrote:
> > IMO sys_readahead() doesn't make sense if the file is opened with
> > O_DIRECT, because the page cache is stuffed but never used. Therefore
> > this patch changes that by letting the call return with -EINVAL.
> > 
> 
> a) It doesn't hurt, it's just a bit of a silly thing to do.

For ocfs that only allows either direct or buffered I/O on a single
inode at a given time it hurts.  It messes up the synchronization
protocol to be exact..

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH][RESEND] don't allow sys_readahead() on files opened with O_DIRECT
    • From: Jan Blunck <[email protected]>
  • Re: [PATCH][RESEND] don't allow sys_readahead() on files opened with O_DIRECT
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: dnotify/inotify and vfs questions
• Next by Date: Re: [PATCH] (18/22) task_thread_info - part 2/4
• Previous by thread: Re: [PATCH][RESEND] don't allow sys_readahead() on files opened with O_DIRECT
• Next by thread: [PATCH] sg.c: fix a memory leak in devices seq_file implementation
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]