[PATCH][RESEND] don't allow sys_readahead() on files opened with O_DIRECT

IMO sys_readahead() doesn't make sense if the file is opened with
O_DIRECT, because the page cache is stuffed but never used. Therefore
this patch changes that by letting the call return with -EINVAL.

Signed-off-by: Jan Blunck <[email protected]>

 mm/filemap.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

Index: experimental-jb/mm/filemap.c
===================================================================
--- experimental-jb.orig/mm/filemap.c
+++ experimental-jb/mm/filemap.c
@@ -1111,7 +1111,8 @@ static ssize_t
 do_readahead(struct address_space *mapping, struct file *filp,
 	     unsigned long index, unsigned long nr)
 {
-	if (!mapping || !mapping->a_ops || !mapping->a_ops->readpage)
+	if (!mapping || !mapping->a_ops || !mapping->a_ops->readpage
+	    || (filp->f_flags & O_DIRECT))
 		return -EINVAL;
 
 	force_page_cache_readahead(mapping, filp, index,

---

• Follow-Ups:
  • Re: [PATCH][RESEND] don't allow sys_readahead() on files opened with O_DIRECT
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: 2.6.13-rc6 JFS Oops trace
• Next by Date: [PATCH] sg.c: fix a memory leak in devices seq_file implementation
• Previous by thread: [PATCH 1/2] pci: Block config access during BIST (resend)
• Next by thread: Re: [PATCH][RESEND] don't allow sys_readahead() on files opened with O_DIRECT
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]