Re: The Linux FAT issue on SD Cards.. maintainer support please

[lsorense@csclub.uwaterloo.ca (Lennart Sorensen)]

On Fri, Aug 19, 2005 at 05:09:06PM +0530, Mukund JB`. wrote:
> To handle it in a similarly in Linux we need to support this driver with
> partitions. There looks a loop hole in the driver. 
> I will verify and fix it today.

I suggest having a look at how other drivers use the add_disk call,
since it calls the partition checking code already in the kernel
automatically as far as I can tell.  You really shouldn't have to write
any of the partition parsing code at all.  You should just have to setup
a structure describing the disk and which major/minor numbers it uses,
and passing that to add_disk and it should deal with the rest.

> Just out of inquisitive ness.
> 
> What r u the minor numbers of those zip devices.
> ll /dev/zip 
> ll /dev/zip4

They are symlinks:
/dev/zip -> /dev/sda
/dev/zip4 -> /dev/sda4

sda uses major,minor: 8,0
sda1: 8.1
sda2: 8,2
...
sda15: 8,15
sdb: 8,16
sdb1: 8.17
...
sdb15: 8,31

That is how scsi does it.

If your driver supports multiple slots at once, decide how many to
support, or decide to only allow a few partitions, and space them by 8
or 16 (allowing 7 and 15 partitions respectively), and it should be easy
to deal with.  sda of course accesses the whole device, while sda1 and
up are for those partitions.  I am pretty sure there is standard
partition handling code in the kernel you should be accessing.

> Thanks for ur support.
> I will check with partition support in the driver & update it.
> Let me fix it there and come back.

Len Sorensen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/