Re: [PATCH] cpm_uart: Fix spinlock initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Aug 12, 2005, at 2:46 PM, Russell King wrote:


On Fri, Aug 12, 2005 at 11:32:57AM -0500, Kumar Gala wrote:


The lack of spin_lock_init causes badness in the preempt


configuration.

Please don't - I have a patch in the wings which fixes this properly.
Unfortunately, its behind a ton of other patches, and I don't want
to try to find all these fixes in each driver.

This is wrong because we will re-initialise it from an indeterminant
state (it might be locked) later during the initialisation.  Let's
fix it properly.

(Since Linus pulled the shutters down when I still had a large chunk
of stuff in my serial tree, my serial patch merging is currently at
a complete standstill.)


Understood.  I'm fine with holding off for your proper fix.

Andrew, let's drop this patch.

- kumar

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]
  Powered by Linux