Re: GFS

Hi David,

+             return -EINVAL;
+     if (!access_ok(VERIFY_WRITE, buf, size))
+             return -EFAULT;
+
+     if (!(file->f_flags & O_LARGEFILE)) {
+             if (*offset >= 0x7FFFFFFFull)
+                     return -EFBIG;
+             if (*offset + size > 0x7FFFFFFFull)
+                     size = 0x7FFFFFFFull - *offset;

Please use a constant instead for 0x7FFFFFFFull. (Appears in various other places as well.) Pekka

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: GFS
    • From: Christoph Hellwig <[email protected]>

• References:
  • [PATCH 00/14] GFS
    • From: David Teigland <[email protected]>
  • Re: [PATCH 00/14] GFS
    • From: Pekka Enberg <[email protected]>
  • Re: [PATCH 00/14] GFS
    • From: David Teigland <[email protected]>

• Prev by Date: Re: GFS
• Next by Date: Re: GFS
• Previous by thread: Re: GFS
• Next by thread: Re: GFS
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]