Re: Calling suspend() in halt/restart/shutdown -> not a good idea

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Tue, 2005-08-02 at 12:04 +0200, Pavel Machek wrote:
> Hi!
> 
> > Why are we calling driver suspend routines in these ? This is _not_ a
> > good idea ! On various machines, the mecanisms for shutting down are
> > quite different from suspend/resume, and current drivers have too many
> > bugs to make that safe. I keep getting all sort of reports of machines
> 
> Well, powerdown at the end of suspend-to-disk should be *very* similar
> to normal powerdown => if device_suspend() breaks something, it is a
> bug in driver anyway.

Power Down != Suspend. Period.

> Now, we may have a lot of such bugs, and the change went in too early,
> but in the long run...

Crap. It's not the same thing.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/