Re: Calling suspend() in halt/restart/shutdown -> not a good idea

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Tue, 2005-08-02 at 11:53 +0200, Pavel Machek wrote:
> Hi!
> 
> > Why are we calling driver suspend routines in these ? This is _not_
> 
> Well, reason is that if you remove device_suspend() you'll get
> emergency hard disk park during powerdown. As harddrives can survive
> only limited number of emergency stops, that is not a good idea.

No, that is bogus. We have shutdown() already for that and it used to be
implemented at least by IDE.

You are just blindly "dropping" the device_suspend() call in there
without thinking. There is a lot of differences between suspend and
shutdown, you can't "just do that". In addition to the number of drivers
with broken suspend of course, causing many boxes to not shutdown
anymore (and not only PPCs)

Andrew, please back that off before 2.6.13. I'll try to send a patch if
you want later today if I find some time with a kernel source at hand.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/