Re: [patch] Support powering sharp zaurus sl-5500 LCD up and down

[Pavel Machek <pavel@ucw.cz>]

Hi!

> >> +	/* read comadj */
> >> +#ifdef CONFIG_MACH_POODLE
> >> +	comadj = 118;
> >> +#else
> >> +	comadj = 128;
> >> +#endif
> >
> > Can you go back to the Sharp source and confirm that these values should
> > be hardcoded in both the poodle and collie cases please? I know the
> > sharpsl_param code can provide them but I can't remember exactly which
> > models use which fields. I want to make sure this isn't a quick hack
> > John made before sharpsl_param was written :).
> 
> No, those values were from the original sharp code...  at some point I was
> going to investigate what values the sharpsl param stuff returned and see
> if those worked.  If the sharpsl stuff works, then by all means use it.

I added code to read it from sharpsl, if it is not there, I use
defaults above. It seems to work on my collie.
							Pavel
-- 
teflon -- maybe it is a trademark, but it should not be.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/