Re: 2.6.13 ub 2/3: Fold one line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



David S. Miller wrote:
From: Pete Zaitcev <[email protected]>
Date: Sat, 30 Jul 2005 22:51:45 -0700


-static ssize_t ub_diag_show(struct device *dev, struct device_attribute *attr, char *page)
+static ssize_t ub_diag_show(struct device *dev, struct device_attribute *attr,
+    char *page)


FWIW, I am generally against this kind of thing at least
for non-static functions.

I used to love this kind of code styling, until I started trying to
often grep a tree to verify the types of arguments to some function.

With the above kind of construct, you get the first few types, but not
all of them, in your grep output.

A better solution would be to stop naming_structures_as_complete_sentences.

IMO there's a happy balance between BSD's squash-everything-into-6-chars style and recent kernel code's tendency to bypass the ancient C 32-char limit.

But ah well ;-)

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]
  Powered by Linux