Re: [PATCH] x86_64: sync_tsc fix the race (so we can boot)

Andi Kleen <[email protected]> writes:

> There are some style problems, but that can be fixed later.
>
> How did you track that nasty it down? 

I had a consistent reproducer.  

I ruled out hangs in the tsc sync code itself,
  by implementing timeouts in all of the loops.

I looked for differences with the ia64 code.

I noticed that sometimes the machine would reboot
and not just hang.

I implemented smp_call_function_single since that was what the ia64
code did.  It worked and all of my pieces of evidence just fell
together.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] x86_64: sync_tsc fix the race (so we can boot)
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH] x86_64: sync_tsc fix the race (so we can boot)
    • From: Andi Kleen <[email protected]>

• Prev by Date: Re: Add prefetch switch stack hook in scheduler function
• Next by Date: RFC: 64-bit resources and changes to pci, ioremap, ...
• Previous by thread: Re: [PATCH] x86_64: sync_tsc fix the race (so we can boot)
• Next by thread: Re: [PATCH] x86_64: sync_tsc fix the race (so we can boot)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]