Re: [2.6 patch] mm/slab: unexport kmem_cache_alloc_node

[Christoph Lameter <christoph@lameter.com>]

On Wed, 27 Jul 2005, Andrew Morton wrote:

> >  	return objp;
> >  }
> > -EXPORT_SYMBOL(kmem_cache_alloc_node);
> >  
> >  #endif
> 
> Even though we don't currently have in-module users, we probably will do so
> soon and it's a part of the slab API and the slab API is exported to
> modules.  I don't see much point in partially-exporting the API and
> applying a patch which we'll soon revert.
> 
> Christoph?
> 

I fully agree. Drivers will have to use that call in the future in order 
to properly place their control structures. The e1000 in your tree already 
does so and may be compiled as a module. Thus applying this patch will 
break mm.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/