Re: [PATCH NFS 3/3] Replace nfs_block_bits() with roundup_pow_of_two()

Trond Myklebust wrote:

må den 25.07.2005 Klokka 17:56 (+0200) skreiv Rene Scharfe:

What's your opinion of the following patch, which explicitly states the
intent of nfs_block_bits()?  It still needs patch 1 and 2.


I really don't like the choice of name. If you feel you must change the
name, then make it something like nfs_blocksize_align(). That describes
its function, instead of the implementation details.


I would agree.  Was there really a driving requirement to change the name?

   Thanx...

      ps
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH NFS 3/3] Replace nfs_block_bits() with roundup_pow_of_two()
  - From: Rene Scharfe <[email protected]>
- Re: [PATCH NFS 3/3] Replace nfs_block_bits() with roundup_pow_of_two()
  - From: Trond Myklebust <[email protected]>
- Re: [PATCH NFS 3/3] Replace nfs_block_bits() with roundup_pow_of_two()
  - From: Trond Myklebust <[email protected]>
- Re: [PATCH NFS 3/3] Replace nfs_block_bits() with roundup_pow_of_two()
  - From: Rene Scharfe <[email protected]>
- Re: [PATCH NFS 3/3] Replace nfs_block_bits() with roundup_pow_of_two()
  - From: Trond Myklebust <[email protected]>

Prev by Date: Re: [ACPI] Re: ACPI buttons in 2.6.12-rc4-mm2
Next by Date: Re: [PATCH 0/23] reboot-fixes
Previous by thread: Re: [PATCH NFS 3/3] Replace nfs_block_bits() with roundup_pow_of_two()
Next by thread: Re: [PATCH NFS 3/3] Replace nfs_block_bits() with roundup_pow_of_two()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind]