If bailing out because there is nothing to receive in rp_do_receive(), tty_ldisc_deref is not called. Failure to do so increases the ref count and causes release_dev() to hang since it can't get the ref count to 0. --- Signed-off-by: Michal Ostrowski <[email protected]> drivers/char/rocket.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/char/rocket.c b/drivers/char/rocket.c --- a/drivers/char/rocket.c +++ b/drivers/char/rocket.c @@ -355,7 +355,7 @@ static void rp_do_receive(struct r_port ToRecv = space; if (ToRecv <= 0) - return; + goto done; /* * if status indicates there are errored characters in the @@ -437,6 +437,7 @@ static void rp_do_receive(struct r_port } /* Push the data up to the tty layer */ ld->receive_buf(tty, tty->flip.char_buf, tty->flip.flag_buf, count); + done: tty_ldisc_deref(ld); }
Attachment:
pgp3QDa87sfc4.pgp
Description: PGP signature
- Prev by Date: Re: Thread_Id
- Next by Date: Re: XFS corruption on move from xscale to i686
- Previous by thread: rcu-refcount stacker performance
- Next by thread: [RFC,PATCH] RCU and CONFIG_PREEMPT_RT semi-sane patch
- Index(es):
