Re: [patch 1/4] drivers/char/ip2/i2lib.c: replace direct assignment with set_current_state()

On 7/8/05, Andrew Morton <[email protected]> wrote:
> [email protected] wrote:
> >
> > @@ -655,7 +655,7 @@ i2QueueCommands(int type, i2ChanStrPtr p
> >                       timeout--;   // So negative values == forever
> >
> >               if (!in_interrupt()) {
> 
> I worry about what this driver is trying to do...
> 
> > -                     current->state = TASK_INTERRUPTIBLE;
> > +                     set_current_state(TASK_INTERRUPTIBLE);
> >                       schedule_timeout(1);    // short nap
> 
> We do this all over the place.  Adding new schedule_timeout_interruptible()
> and schedule_timeout_uninterruptible() would reduce kernel size and neaten
> things up.

I'll get a patch and users set up soon to do just this.

Thanks,
Nish
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch 1/4] drivers/char/ip2/i2lib.c: replace direct assignment with set_current_state()
    • From: [email protected]
  • Re: [patch 1/4] drivers/char/ip2/i2lib.c: replace direct assignment with set_current_state()
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: share/private/slave a subtree - define vs enum
• Next by Date: [2.6 patch] Documentation/Changes: document the required udev version
• Previous by thread: Re: [patch 1/4] drivers/char/ip2/i2lib.c: replace direct assignment with set_current_state()
• Next by thread: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]