On Thu, 2005-06-16 at 07:33 -0400, Steven Rostedt wrote:
> int do_setitimer(int which, struct itimerval *value, struct itimerval *ovalue)
> {
> struct task_struct *tsk = current;
> static spinlock_t lock = SPIN_LOCK_UNLOCKED;
>
> [...]
> spin_lock(&lock);
> spin_unlock(&tsk->sighand->siglock);
> del_timer_sync(&tsk->signal->real_timer);
> spin_lock(&tsk->sighand->siglock);
> spin_unlock(&lock);
OK, I just got out of bed, so I'm not too with it :-)
This is pretty much a guaranteed deadlock! So the first spin_lock needs
to go before the siglock. That should do it!
case ITIMER_REAL:
spin_lock_irq(&lock);
spin_lock(&tsk->sighand->siglock);
[...]
spin_unlock(&tsk->sighand->siglock);
del_timer_sync(&tsk->signal->real_timer);
spin_lock(&tsk->sighand->siglock);
spin_unlock(&lock);
We just need to keep two do_setitimer calls from grabbing the siglock.
That first string of code didn't prevent that.
-- Steve
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
