Re: [RFC PATCH] PCI: remove access to pci_[enable|disable]_msi() for drivers - take 2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andrew Grover wrote:
On 6/7/05, Jeff Garzik <[email protected]> wrote:
Also, it looks like all the PCI MSI drivers need touching for this
scheme -- which defeats the original intention.  At this rate, the best
API is the one we've already got.


For now...but I'm bringing this up again in five years!! *sets egg timer*


Re-read the start of the thread :)

My suggestion...

short term:  do nothing

long term: move drivers to a new pci_enable()/pci_disable() API which makes it easy for us to roll a lot of these singleton function calls, repeated over and over again in PCI drivers, into generic code.

Then just let evolution happen. That way, progress occurs, but no existing drivers are broken by a sudden pci_enable_device() behavior change.

Since we're in a "rolling stable series" that might be a better path to take. If evolution goes as expected, maybe there will no longer be any public users of pci_enable_msi()...

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux