Re: [rfc] [patch] consolidate/clean up spinlock.h files

Hi Ingo,

Ingo Molnar wrote:
> * Ingo Oeser <[email protected]> wrote:
> > you wrote:
> > > --- linux/lib/spinlock_debug.c.orig
> > I would suggest propagating the __FILE__ and __LINE__ from the CALLERS
> the real call site info comes from dump_stack(). Maybe i should remove
> the __FILE__,__LINE__ info altogether. (albeit a bit redundancy wont
> hurt) I dont think we want to pass in __FILE__,__LINE__ all the way from
> the main APIs.

Then please remove the __FILE__ and __LINE__ altogether.

It looks confusing to me and enlarges code without providing
any useful additional information.


Regards

Ingo Oeser

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [rfc] [patch] consolidate/clean up spinlock.h files
    • From: Ingo Molnar <[email protected]>
  • Re: [rfc] [patch] consolidate/clean up spinlock.h files
    • From: Ingo Oeser <[email protected]>
  • Re: [rfc] [patch] consolidate/clean up spinlock.h files
    • From: Ingo Molnar <[email protected]>

• Prev by Date: Re: Tyan Opteron boards and problems with parallel ports (badpmd)
• Next by Date: Re: [PATCH 1/3] eCryptfs: eCryptfs kernel module
• Previous by thread: Re: [rfc] [patch] consolidate/clean up spinlock.h files
• Next by thread: Re: [rfc] [patch] consolidate/clean up spinlock.h files
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]