Re: [rfc] [patch] consolidate/clean up spinlock.h files

Hi Ingo,
you wrote:

> --- linux/lib/spinlock_debug.c.orig
> +++ linux/lib/spinlock_debug.c
> +#define SPIN_BUG_ON(cond, lock, msg) \
> +		if (unlikely(cond)) spin_bug(lock, __FILE__, __LINE__, msg)
> +#define RWLOCK_BUG_ON(cond, lock, msg) \
> +		if (unlikely(cond)) rwlock_bug(lock, __FILE__, __LINE__, msg)

I would suggest propagating the __FILE__ and __LINE__ from the CALLERS 
of those functions in lib/spinlock_debug.c into these macros, to make
this info more useful. At the moment you just know, that the bug happend
on some spinlock/rwlock, but not who caused this.


Regards

Ingo Oeser

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [rfc] [patch] consolidate/clean up spinlock.h files
    • From: Zwane Mwaikambo <[email protected]>
  • Re: [rfc] [patch] consolidate/clean up spinlock.h files
    • From: Ingo Molnar <[email protected]>

• References:
  • [rfc] [patch] consolidate/clean up spinlock.h files
    • From: Ingo Molnar <[email protected]>

• Prev by Date: Re: SD_SHARE_CPUPOWER breaks scheduler fairness
• Next by Date: Re: Avoiding external fragmentation with a placement policy Version 12
• Previous by thread: [rfc] [patch] consolidate/clean up spinlock.h files
• Next by thread: Re: [rfc] [patch] consolidate/clean up spinlock.h files
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]