Re: Hotplug CPU printk issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>>>> On Wed, 25 May 2005 22:52:04 -0700, Andrew Morton <[email protected]> said:

  Andrew> Shaohua Li <[email protected]> wrote:

  >> > Please confirm that we in fact do not want to allow downed CPUs to
  >> > print things, then send a patch.
  >> Yep. In the cpu hotplug case, per-cpu data possibly isn't initialized
  >> even the system state is 'running'. As the comments say in the original
  >> code, some console drivers assume per-cpu resources have been allocated.
  >> radeon fb is one such driver, which uses kmalloc. After a CPU is down,
  >> the per-cpu data of slab is freed, so the system crashed when printing
  >> some info.

  Andrew> hm, that certainly sounds sane, but I do recall there were
  Andrew> reasonable-sounding reasons why the ia64 guys wanted
  Andrew> printk-on-a-down-CPU to work.  Hopefully David can remember
  Andrew> what the problem was so we can find a more thorough fix.

I don't recall having submitted such a patch.  According to the bk
log, it was Rusty who added the !system_running check (which was later
changed to system_state != SYSTEM_RUNNING).

The changelog only says:

 "- Allow printk on down cpus once system is running"

Rusty?

	--david
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux