Shaohua Li <[email protected]> wrote:
>
> > --- a/kernel/printk.c 2005-04-12 10:12:19.000000000 +0800
> > +++ b/kernel/printk.c 2005-04-13 17:22:40.912897328 +0800
> > @@ -624,8 +624,7 @@ asmlinkage int vprintk(const char *fmt,
> > log_level_unknown = 1;
> > }
> >
> > - if (!cpu_online(smp_processor_id()) &&
> > - system_state != SYSTEM_RUNNING) {
> > + if (!cpu_online(smp_processor_id())) {
> > /*
> > * Some console drivers may assume that per-cpu resources have
> > * been allocated. So don't allow them to be called by this
> Andrew,
> Could above patch be put into mm tree?
Well not in that form. I'd appreciate being sent patches which are
applyable rather than mangled messes, please.
> It fixes the oops of CPU hotplug
> with radeon fb enabled.
> The reason is the per-cpu data (radeon fb calls kmalloc) isn't
> initialized when CPU hotplug is processing. system_state is
> SYSTEM_RUNNING for cpu hotplug.
That system_state test was explicitly added by davidm a year ago:
"- Allow printk on down cpus once system is running."
Please confirm that we in fact do not want to allow downed CPUs to
print things, then send a patch.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]