Re: Oops on CF removal and "convert device drivers to driver-model"

[Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>]

On Tue, 17 May 2005, Pete Zaitcev wrote:

> On Tue, 17 May 2005 23:17:04 +0200, Pozsár Balázs <pozsy@uhulinux.hu> wrote:
>
> > On Sat, May 14, 2005 at 01:50:19PM -0700, Pete Zaitcev wrote:
> > > @@ -1138,7 +1133,8 @@ static int idescsi_attach(ide_drive_t *d
> > >  	idescsi->host = host;
> > >  	idescsi->disk = g;
> > >  	g->private_data = &idescsi->driver;
> > > -	err = ide_register_subdriver(drive, &idescsi_driver);
> > > +	ide_register_subdriver(drive, &idescsi_driver);
> > > +	err = 0;
> > >  	if (!err) {
> > >  		idescsi_setup (drive, idescsi);
> > >  		g->fops = &idescsi_ops;
> >
> > !err cannot be true here, so this seems buggy.

check for !err is always true here and can be removed

> Indeed.
>
> Unfortunately, Andrew's scripts notified me that he added the patch to
> his tree, so I'd need to wait for a turnaround before a fix-over-fix.

Pete, the version of the patch you've posted is not the final one
- it misses ->probe() return value fixes.

I'll push the fixed one to Linus.

Thanks,
Bartlomiej