Re: Oops on CF removal and "convert device drivers to driver-model"

On Sat, May 14, 2005 at 01:50:19PM -0700, Pete Zaitcev wrote:
> @@ -1138,7 +1133,8 @@ static int idescsi_attach(ide_drive_t *d
>  	idescsi->host = host;
>  	idescsi->disk = g;
>  	g->private_data = &idescsi->driver;
> -	err = ide_register_subdriver(drive, &idescsi_driver);
> +	ide_register_subdriver(drive, &idescsi_driver);
> +	err = 0;
>  	if (!err) {
>  		idescsi_setup (drive, idescsi);
>  		g->fops = &idescsi_ops;


!err cannot be true here, so this seems buggy.




-- 
pozsy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: Oops on CF removal and "convert device drivers to driver-model"
    • From: Pete Zaitcev <[email protected]>

• References:
  • Oops on CF removal and "convert device drivers to driver-model"
    • From: Pete Zaitcev <[email protected]>

• Prev by Date: Re: software mixing in alsa
• Next by Date: Re: [PATCH] uml: remove elf.h
• Previous by thread: Oops on CF removal and "convert device drivers to driver-model"
• Next by thread: Re: Oops on CF removal and "convert device drivers to driver-model"
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]