Re: [PATCH] kernel/module.c has something to hide. (whitespace cleanup)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Paulo Marques wrote:
Adrian Bunk wrote:

On Wed, May 11, 2005 at 12:07:55PM +0100, Paulo Marques wrote:
[...]

Just a small sugestion: do a sha (or md5sum, or whatever hash function you prefer) to vmlinux before and after applying the patches.

If all is well, it shouldn't change (since this is just whitespace cleanup), and it is a little more robust than just checking the size.

That's wrong.

vmlinux contains the date of the compilation.

You're right, I forgot about that...

Removing UTS_VERSION from init/version.c would make this work, or are there other places where this might be a problem?

Ok, I've just tested this.

At least with my config, if I remove both instances of UTS_VERSION from init/version.c, the resulting vmlinux files are exactly identical with the same sha1sum.

So maybe Jesper can use this to make *really* sure that there are no actual changes with the patches, just whitespace changes.

--
Paulo Marques - www.grupopie.com

An expert is a person who has made all the mistakes that can be
made in a very narrow field.
Niels Bohr (1885 - 1962)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux