Re: [PATCH] kernel/module.c has something to hide. (whitespace cleanup)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 10 May 2005, David S.Miller wrote:

> From: Andrew Morton <[email protected]>
> Subject: Re: [PATCH] kernel/module.c has something to hide. (whitespace cleanup)
> Date: Tue, 10 May 2005 17:02:46 -0700
> 
> > Well I suppose I could live with a few REALLY REALLY BIG patches to do this
> > to lots of files, but if it's the old death-by-1000-cuts, I'm gonna call
> > uncle this time.
> 
> Fair enough.  One should be able to regex the majority of them
> with a check for "if *(" then ";" on the same line.
> 
Indeed.

If Andrew agrees, then I'll commit to doing this cleanup;

- no two statements on same line
- no funky spaces between function names, arguments etc.
- no spaces instead of proper tabs.
- (to a limited degree) no trailing whitespace
- perhaps other whitespace cleanups as per Codingstyle

For the entire tree.

No actual code changes - should be resonably easy to review.

Some can be semi-automated, some can't, and it'll take time and be a 
royal pain. But if Andrew will take the patches I'll do it (in some 2 
digit nr of patches (aiming for <50 - obviously guessing wildly here)).

I'll need time to do this - no matter how you cut it there are a lot of 
files, and a lot of lines - so don't expect the patch bombing to start for 
the next few weeks.
And before I embark on this venture I'd like some feedback that when I do 
turn up with patches they'll have a resonable chance of getting merged - 
this is going to be a lot of boring work, and with no commitment to merge 
anything it's not something I want to waste days on...  Sounds fair?

Ohh, and I'd be submitting all the patches to you Andrew, not individual 
maintainers/authors..


-- 
Jesper


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux