Re: [PATCH]porting lockless mce from x86_64 to i386

[Bill Davidsen <davidsen@tmr.com>]

Pallipadi, Venkatesh wrote:

> I think what Andi meant was that instead of copying code from x86-64 
> to i386 and making x86-64 link to this i386 copy, you can leave the 
> code in x86-64 and link it from i386 part of the tree. 
>
> Doing it either way should be OK with this mce code. But I feel, 
> despite of the patch size, it is better to keep all the shared 
> code in i386 tree and link it from x86-64. Otherwise, it may become 
> kind of messy in future, with various links between i386 and x86-64.
> Andi/Andrew: What do you suggest here?

Have you considered having a tree just for the shared code and links 
where appropriate? If nothing else that would make it blindingly obvious 
 that the code was shared, and avoid having someone do something 
unsharable because s/he didn't know there was a pointer to the code 
elsewhere.

I know it's slightly more complex, but also slightly safer.

--
   -bill davidsen (davidsen@tmr.com)
"The secret to procrastination is to put things off until the
 last possible moment - but no longer"  -me

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/