Re: [CHECKER] possible missing capability check in ioctl function, drivers/net/cris/eth_v10.c, kernel 2.6.11

* Ted Kremenek ([email protected]) wrote:
> In several network drivers that handle the ioctl command SIOCSMIIREG 
> (writes a register on the network card) most implementations check for 
> the CAP_NET_ADMIN capability.  Several drivers use the function 
> "generic_mii_ioctl" to process this command (defined in 
> drivers/net/mii.c).  In mii.c, we see:

This, to me, looks like the device specific (or generic_mii_ioctl)
capability test winds up being redundant.  The top-level checks
capabilities already in net/dev/core.c::dev_ioctl().  So, while there's
some room for cleanup, I don't think this is an acutal bug.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [CHECKER] possible missing capability check in ioctl function, drivers/net/cris/eth_v10.c, kernel 2.6.11
    • From: Ted Kremenek <[email protected]>

• Prev by Date: Re: Further copy_from_user() discussion.
• Next by Date: Kernel Rootkits
• Previous by thread: Re: [CHECKER] possible missing capability check in ioctl function, drivers/net/cris/eth_v10.c, kernel 2.6.11
• Next by thread: Booting from USB with initrd
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]